Skip to content

Adjust zlog warning and error message in FPM kqueue event #14053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Adjust zlog warning and error message in FPM kqueue event #14053

merged 1 commit into from
Apr 28, 2024

Conversation

pesc
Copy link
Contributor

@pesc pesc commented Apr 26, 2024

This is just a small pull requests changing some strings and does not fix any bugs.

This merge request modifies the zlog warning and error message in the kqueue fpm-event (sapi/fpm/fpm/events/). These were incorrect, presumably the kqueue code was written based on the epoll code, and it was forgotten to adjust the strings accordingly. This improves it.

@pesc pesc requested a review from bukka as a code owner April 26, 2024 13:37
@devnexen
Copy link
Member

it kind of qualify as fix, even though not major at all. But bukka will say.

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for master. I prefer not to change log messages in the lower branches as there might be tools depending on the error messages.

@bukka bukka merged commit 57cd23d into php:master Apr 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants